Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return err after roll back #641

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jun 6, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG June 6, 2024 14:39
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.94%. Comparing base (b099995) to head (a52d2ad).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/aliyun/client/ecs.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   23.08%   22.94%   -0.14%     
==========================================
  Files          62       62              
  Lines        6493     6554      +61     
==========================================
+ Hits         1499     1504       +5     
- Misses       4757     4809      +52     
- Partials      237      241       +4     
Flag Coverage Δ
unittests 22.94% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 23ef06f into AliyunContainerService:main Jun 7, 2024
7 of 9 checks passed
@l1b0k l1b0k deleted the fix/err branch July 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants